Howdy, Stranger!
It looks like you're new here. If you want to get involved, click one of these buttons!
Arrays and if macros
How do I make sure that an array does not have more than a set amount of a variable? I've already looked at the Sugarcube 2 library and the count and includes macros don't seem to work with if macros.
Please let me know what I'm doing wrong.
<<if $mapArray.count("3") gt 7>>
<<set $mapArray.("3") to 7>>
<</if>>
Please let me know what I'm doing wrong.
Comments
I believe you are confusing two things:
1. Counting the number of times a particular value appears within an array.
This is what the Array count() function does, as demonstrated by the following:
Number of B's in array is: <<= $array.count("B") >> Is there more than one B?: \ <<if $array.count("B") gt 1>>Yes<<else>>No<</if>>2. Accessing and assigning the value of a particular element of an array.
note: SugarCube and Javascript arrays are zero based which means that the first array element has an index of 0 not 1.
I'm trying to ensure that "3" doesn't appear more than 7 times in the randomly generated array.
Before I suggest a solution I need to know if you actually need the $lineXmap ($line1map to $line30map) variables or can I get rid of them?
The following Javascript is one way to achieve your desired result and it needs to be placed within your story's Story Javascript area. It generates an array named $mapArray which has 30 elements and each of those elements contains a child 30 element array full of random numbers.
var _i, _j, _value, _threeCount = 0; /* list of possible values */ var _options = [1, 1, 1, 1, 1, 1, 1, 2, 2, 3, 4, 5, 6, 6, 6]; /* create the parent array. */ var _size = 30; var _array = new Array(_size); for (_i = 0; _i < _size; _i++) { /* create the child array for the current parent element. */ _array[_i] = new Array(_size); for (_j = 0; _j < _size; _j++) { /* default value used in first and last elements of parent array. */ _value = 0; /* determine random value of other parent elements. */ if (_i > 0 && _i < (_size - 1)) { _value = _options.random(); /* track the number of 3's */ if (_value == 3) { _threeCount++; if (_threeCount > 7) { /* remove 3 from option list. */ _options.splice(9, 1); _value = _options.random(); } } } _array[_i][_j] = _value; } } /* create story variable to contain parent array. */ State.variables["mapArray"] = _array;note: there are a number of ways the above code can be condensed and improved, I wrote it long-hand so you can see the steps involved. The above could also be written using TwineScript but because of the inherent overhead involved I felt Javascript would be a better choice.Generating a random array of 1's, 2's, 4's, 5s and 6's and then picking 7 random cells to overwrite with 3's is going to give you a better distribution of 3's than your current method.
Unless you've been very careful to tune your probabilities, the 3's will tend to appear in the first few lines of your array. The chance of any cell containing a 3 is 1 in 15. You've got 30 cells in each line, so that would give you an average of 2 3's in each line. On average you should expect to have 7 threes on the map by the end of your 4th row. Exceptional cases might get as far as the 8th row. Highly unlikely to find any 3's in the bottom 22 rows.
Might save yourself some typing if you look into whether or not your either takes an array as an argument. I think the later ones do.
var _i, _j, _value, _ind, _threes = []; /* list of possible values */ var _options = [1, 1, 1, 1, 1, 1, 1, 2, 2, 3, 4, 5, 6, 6, 6]; /* create the parent array. */ var _size = 30; var _array = new Array(_size); for (_i = 0; _i < _size; _i++) { /* create the child array for the current parent element. */ _array[_i] = new Array(_size); for (_j = 0; _j < _size; _j++) { /* default value used in first and last elements of parent array. */ _value = 0; /* determine random value of other parent elements. */ if (_i > 0 && _i < (_size - 1)) { _value = _options.random(); /* track the location of the 3's */ if (_value == 3) { _threes.push([_i, _j]) } } _array[_i][_j] = _value; } } /* remove 3 from option list. */ _options.splice(9, 1); /* randomly remove unwanted 3's */ while (_threes.length > 7) { _ind = _threes.pluck(); _i = _ind[0]; _j = _ind[1]; _array[_i][_j] = _options.random(); } /* create story variable to contain parent array. */ State.variables["mapArray"] = _array;note: again there are a number of ways the above code can be condensed and improved.