User Tools

Site Tools


twine_1.4.2_bugs

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
twine_1.4.2_bugs [2014/12/15 23:56]
l
twine_1.4.2_bugs [2017/10/09 20:39] (current)
Line 1: Line 1:
 This is a list of bugs in Twine 1.4.2. Some of these may be carryovers from Twine 1.4.1, and some may be newly introduced. All of these will be fixed in a future release. This is a list of bugs in Twine 1.4.2. Some of these may be carryovers from Twine 1.4.1, and some may be newly introduced. All of these will be fixed in a future release.
 +
 +=====Image syntax doesn'​t work with external URLs=====
 +
 +Due to a bug, the image syntax in 1.4.2 only works with imported image resources - external URLs will silently fail to load.
 +
 +====Patch====
 +
 +To fix this, simply install this repair code in a [[script]] passage:
 +<​code>​
 +    Wikifier.imageFormatter.importedImage = function(img,​ passageName) {
 +        var imgPassages,​ imgname;
 +        // Try to parse it as a variable
 +        try {
 +            imgname = internalEval(Wikifier.parse(passageName));​
 +        }
 +        catch(e) {
 +        }
 +        if (!imgname) {
 +            imgname = passageName;​
 +        }
 +        // Base64 passage transclusion
 +        imgPassages = tale.lookup("​tags",​ "​Twine.image"​);​
 +        for (j = 0; j < imgPassages.length;​ j++) {
 +            if (imgPassages[j].title == imgname) {
 +                img.src = imgPassages[j].text;​
 +                return;
 +            }
 +        }
 +        img.src = imgname;
 +    }
 +</​code>​
  
 =====No History.prototype.display warning===== =====No History.prototype.display warning=====
Line 44: Line 75:
  
 The bookmark link has proved to be a massive perf drain when a story uses JS objects in variables. It should really only be computed when the player actually clicks the link. The bookmark link has proved to be a massive perf drain when a story uses JS objects in variables. It should really only be computed when the player actually clicks the link.
- 
-=====No tabIndexes for passage links===== 
- 
-A keyboard accessibility concern: in some browsers, Twine passage links can't be navigated to via the Tab key, because their elements lack tabindex attributes. 
- 
-====Makeshift patch==== 
-Thomas M. Edwards provides this script as a makeshift patch: 
-<​code>​postrender.addTabIndexes = function (content) { 
- var links = content.querySelectorAll("​a"​);​ 
- for (var i = 0, len = links.length;​ i < len; i++) { 
- links[i].setAttribute("​tabindex",​ 0); 
- } 
-}; 
-</​code>​ 
  
 =====visited() error checking===== ​ =====visited() error checking===== ​
twine_1.4.2_bugs.1418705796.txt.gz ยท Last modified: 2017/10/09 20:38 (external edit)